Re: [PATCH v1 5/7] MIPS: BCM63XX: Remove one time use ephy_reset_gpio_flags

[Thomas Bogendoerfer]

On Wed, Jul 15, 2026 at 08:46:45PM +0200, Andy Shevchenko wrote:
> ephy_reset_gpio_flags exists solely to supply polarity to the reset GPIO.
> But in practice it's kept all the same and currently only a single user
> present. Drop the member and use hard coded GPIO flags instead.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
>  arch/mips/bcm63xx/boards/board_bcm963xx.c           | 7 +++----
>  arch/mips/include/asm/mach-bcm63xx/board_bcm963xx.h | 3 ---
>  2 files changed, 3 insertions(+), 7 deletions(-)
> 
> diff --git a/arch/mips/bcm63xx/boards/board_bcm963xx.c b/arch/mips/bcm63xx/boards/board_bcm963xx.c
> index c5617b889b1c..57e916c06792 100644
> --- a/arch/mips/bcm63xx/boards/board_bcm963xx.c
> +++ b/arch/mips/bcm63xx/boards/board_bcm963xx.c
> @@ -42,7 +42,7 @@ static struct board_info __initdata board_cvg834g = {
>  	.expected_cpu_id = 0x3368,
>  
>  	.ephy_reset_gpio = 36,
> -	.ephy_reset_gpio_flags = GPIOF_OUT_INIT_HIGH,
> +
>  	.has_pci = 1,
>  	.has_uart0 = 1,
>  	.has_uart1 = 1,
> @@ -903,9 +903,8 @@ int __init board_register_devices(void)
>  
>  	platform_device_register(&bcm63xx_gpio_leds);
>  
> -	if (board.ephy_reset_gpio && board.ephy_reset_gpio_flags)
> -		gpio_request_one(board.ephy_reset_gpio,
> -				board.ephy_reset_gpio_flags, "ephy-reset");
> +	if (board.ephy_reset_gpio)
> +		gpio_request_one(board.ephy_reset_gpio, GPIOF_OUT_INIT_HIGH, "ephy-reset");
>  
>  	return 0;
>  }
> diff --git a/arch/mips/include/asm/mach-bcm63xx/board_bcm963xx.h b/arch/mips/include/asm/mach-bcm63xx/board_bcm963xx.h
> index 830f53f28e3f..018a56cbc328 100644
> --- a/arch/mips/include/asm/mach-bcm63xx/board_bcm963xx.h
> +++ b/arch/mips/include/asm/mach-bcm63xx/board_bcm963xx.h
> @@ -46,9 +46,6 @@ struct board_info {
>  
>  	/* External PHY reset GPIO */
>  	unsigned int ephy_reset_gpio;
> -
> -	/* External PHY reset GPIO flags from gpio.h */
> -	unsigned long ephy_reset_gpio_flags;
>  };
>  
>  #endif /* ! BOARD_BCM963XX_H_ */
> -- 
> 2.50.1

Acked-by: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]