Re: [PATCH v1 6/7] MIPS: BCM63XX: Open code gpio_request_one()

[Thomas Bogendoerfer]

On Wed, Jul 15, 2026 at 08:46:46PM +0200, Andy Shevchenko wrote:
> Open code the gpio_request_one() call to be able to kill that API
> in the follow changes.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
>  arch/mips/bcm63xx/boards/board_bcm963xx.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/mips/bcm63xx/boards/board_bcm963xx.c b/arch/mips/bcm63xx/boards/board_bcm963xx.c
> index 57e916c06792..993341604439 100644
> --- a/arch/mips/bcm63xx/boards/board_bcm963xx.c
> +++ b/arch/mips/bcm63xx/boards/board_bcm963xx.c
> @@ -903,8 +903,11 @@ int __init board_register_devices(void)
>  
>  	platform_device_register(&bcm63xx_gpio_leds);
>  
> -	if (board.ephy_reset_gpio)
> -		gpio_request_one(board.ephy_reset_gpio, GPIOF_OUT_INIT_HIGH, "ephy-reset");
> +	if (board.ephy_reset_gpio) {
> +		gpio_request(board.ephy_reset_gpio, "ephy-reset");
> +		gpio_direction_output(board.ephy_reset_gpio, 1);
> +		gpio_free(board.ephy_reset_gpio);
> +	}
>  
>  	return 0;
>  }
> -- 
> 2.50.1

Acked-by: Thomas Bogendoerfer <tsbogend@xxxxxxxxxxxxxxxx>

-- 
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea.                                                [ RFC1925, 2.3 ]