Re: [PATCH v4] scsi: arm: Convert acornscsi-io.S to C

[Jonathan Corbet]

Breno Rodrigues Alves <breno3011alves@xxxxxxxxx> writes:

> The Acorn SCSI expansion card presents each 16-bit SCSI data halfword
> on the low half of a 32-bit card access.  The hand-written assembly
> in acornscsi-io.S implements the two directions of the data path:
>
>   - __acornscsi_in()  : packs pairs of 16-bit card reads into 32-bit
>                         memory words
>   - __acornscsi_out() : expands 16-bit memory halfwords into 32-bit
>                         card writes (duplicating the halfword in both
>                         halves for the bulk of the transfer)
>
> Both routines are simple pointer walks that a modern compiler handles
> just as well as hand-written assembly, so replace the .S file with an
> equivalent C implementation.

How have you tested this change?

jon