Re: [PATCH v10 01/28] KVM: VMX: Enable support for secondary VM exit controls

From: Sohil Mehta

Date: Thu Oct 22 2026 - 22:10:22 EST


On 10/22/2026 2:27 AM, Binbin Wu wrote:

>>
>> Signed-off-by: Xin Li (Intel) <xin@xxxxxxxxx>
>> Signed-off-by: Sohil Mehta <sohil.mehta@xxxxxxxxx>
>
> Reviewed-by: Binbin Wu <binbin.wu@xxxxxxxxxxxxxxx>
>

Thank you for reviewing the patches.

> [...]
>
>> diff --git a/arch/x86/kvm/vmx/vmx.c b/arch/x86/kvm/vmx/vmx.c
>> index 504630f0eb40..b4aec4218b7d 100644
>> --- a/arch/x86/kvm/vmx/vmx.c
>> +++ b/arch/x86/kvm/vmx/vmx.c
>> @@ -2751,8 +2751,9 @@ static int setup_vmcs_config(struct vmcs_config *vmcs_conf,
>> u32 _cpu_based_exec_control = 0;
>> u32 _cpu_based_2nd_exec_control = 0;
>> u64 _cpu_based_3rd_exec_control = 0;
>> - u32 _vmexit_control = 0;
>> u32 _vmentry_control = 0;
>> + u32 _vmexit_control = 0;
>> + u64 _vmexit2_control = 0;
>
>
> Nit:
> Could be _vmexit_2nd_control to be consistent with _cpu_based_2nd_exec_control
> above, as well as vmexit_2nd_control in struct vmcs_config.
>

Sure, will update it.