Re: [PATCH v2 3/3] watchdog: dw_wdt: clean up error paths in resume function
From: Tzung-Bi Shih
Date: Thu Oct 22 2026 - 23:07:05 EST
On Thu, Oct 22, 2026 at 04:43:51PM +0300, Artem Shimko wrote:
> Clean up of dw_wdt_resume() function.
>
> Rework the error handling to use properly named labels that match the
> cleanup order. Use unprepare_clk for clock disable and unprepare_pclk
> for pclk disable path.
>
> Signed-off-by: Artem Shimko <a.shimko.dev@xxxxxxxxx>
See [PATCH v2 2/3]. I'd suggest squashing this patch into [v2 2/3].
> @@ -393,16 +393,15 @@ static int dw_wdt_suspend(struct device *dev)
> static int dw_wdt_resume(struct device *dev)
> {
> struct dw_wdt *dw_wdt = dev_get_drvdata(dev);
> - int err = clk_prepare_enable(dw_wdt->clk);
> + int err;
>
> + err = clk_prepare_enable(dw_wdt->clk);
This is an additional change, but I think it's fine to squash.