Re: [PATCH v2 1/4] serial: 8250_omap: separate locked TX DMA completion processing

[Andy Shevchenko]

On Thu, Oct 22, 2026 at 06:34:02PM -0600, James Hilliard wrote:
> Separate the port-locked completion processing from the DMA callback
> wrapper. Keep the shutdown check and locking in the callback, and retain
> the existing FIFO accounting, delayed register restore and THRI handling
> in the helper.

...

> +static void omap_8250_dma_tx_complete(void *param)
> +{
> +	struct uart_8250_port *p = param;
> +	struct uart_8250_dma *dma = p->dma;
> +
> +	guard(uart_port_lock_irqsave)(&p->port);

> +	if (!dma->shutting_down)
> +		omap_8250_tx_dma_complete(p);

Taking into account the name and the purpose of the function I would refactor
this to

	if (dma->shutting_down)
		return;

	omap_8250_tx_dma_complete(p);

> +}

-- 
With Best Regards,
Andy Shevchenko