Re: [PATCH] mtd: spi-nor: swp: remove unnecessary else after return

From: Shuai Liu

Date: Fri Oct 23 2026 - 05:35:24 EST


On Fri, Oct 23, 2026, Michael Walle wrote:
> So what is the checkpatch warning? IMHO that change make the
> readability worse.

It's the "else is not generally useful after a break or return"
check in checkpatch.pl.

Fair point. With the comments attached to both branches, the
symmetric if/else reads fine, and I agree this isn't worth
changing. Please drop this patch.

Sorry for the noise.

Best regards,
Shuai Liu