Re: [PATCH rtw-next v4] wifi: rtw88: pci: wake the TX queues after restart_hw and interface up

[Abdurrahman Karadag]

> It would look natural to clear queue_stopped before enabling interrupt,
> since it is intended to reset. More, add a function to be clear that we
> are resetting queue_stopped, like rtw_pci_reset_tx_{ring or queue}_state().

Done in v5 as rtw_pci_reset_tx_queue_state(), called first inside the
irq_lock section. It carries lockdep_assert_held(&rtwpci->irq_lock)
like rtw_pci_deep_ps_enter() does, to record that the caller holds it.

> Add an empty line before 'running = true'.

Done.

> For scanning from idle case, we have an assistant
> 'test_bit(RTW_FLAG_SCANNING, rtwdev->flags)' if you want.

The case is real - rtw_hw_scan_start() takes the stop before it reaches
rtw_core_scan_start(), so the stop is already standing when the start
runs. The flag is not: rtw_core_scan_start() calls rtw_leave_ips() and
only sets RTW_FLAG_SCANNING at the end of the same function, and that is
the one set_bit() for it in the driver. So the test would read false
exactly when the scan's stop is up, and I left it out rather than add a
check that cannot fire there.