RE: [PATCH v24 10/15] mmc: renesas_sdhi: Add write32_hook for CTL_SD_CARD_CLK_CTL register writes
From: Biju Das
Date: Fri Oct 23 2026 - 10:32:09 EST
Hi Wolfram,
> -----Original Message-----
> From: wsa+renesas <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> Sent: 22 October 2026 11:01
> Subject: Re: [PATCH v24 10/15] mmc: renesas_sdhi: Add write32_hook for CTL_SD_CARD_CLK_CTL register
> writes
>
>
> > For safer side I will add, considering this code is used by other
> > vendors they may call sd_ctrl_write32() in future with no TMIO_MMC_HAS_IDLE_WAIT flag.
> > Currently all Renesas SoCs have this flag set.
> >
> > if (!(pdata->flags & TMIO_MMC_HAS_IDLE_WAIT)) {
> > _host->write16_hook = NULL;
> > _host->write32_hook = NULL; }
>
> Yes, please. The consistency that comes with it is also helpful.
Agreed.
Cheers,
Biju