Re: [PATCH v6? 3/7] RDMA/zrdma: Add internal headers and hardware register definitions

[Markus Elfring]

Please specify version identifications in a consistent way.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.3#n711
https://lore.kernel.org/linux-rdma/20261024071539.2182864-1-zhang.yanze@xxxxxxxxxx/


…
> +++ b/drivers/infiniband/hw/zrdma/zrdma_main.h
> @@ -0,0 +1,216 @@
…
> +static inline void zxdh_free_rsrc(struct zxdh_pci_f *rf,
> +				  unsigned long *rsrc_array, u32 rsrc_num)
> +{
> +	unsigned long flags;
> +
> +	spin_lock_irqsave(&rf->rsrc_lock, flags);
> +	__clear_bit(rsrc_num, rsrc_array);
> +	spin_unlock_irqrestore(&rf->rsrc_lock, flags);
> +}
…

Under which circumstances would you become interested to apply a statement
like “guard(spinlock_irqsave)(&rf->rsrc_lock);”?
https://elixir.bootlin.com/linux/v7.3/source/include/linux/spinlock.h#L642-L645


See also:
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v7.3#n977

Regards,
Markus