Re: [PATCH v2 1/3] drm/vc4: Implement vc6_hdmi_phy_disable

[Maíra Canal]

Hi Lucas,

On 20/10/26 12:19, Lucas Tanure wrote:
> From: Dom Cobley <popcornmix@xxxxxxxxx>
>
> The body of this function was missing so we don't reset the phy
> when disabling it.

Please, improve this commit message. At the moment, it's not explaining
what's is fixing, nor how.

Best regards,
- Maíra
> Fixes: 0b1dbe82e051 ("drm/vc4: hdmi: Add support for BCM2712 HDMI controllers")
> Signed-off-by: Dom Cobley <popcornmix@xxxxxxxxx>
> Signed-off-by: Lucas Tanure <lucas.tanure@xxxxxxx>
> ---
>   drivers/gpu/drm/vc4/vc4_hdmi_phy.c | 5 +++++
>   1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/vc4/vc4_hdmi_phy.c b/drivers/gpu/drm/vc4/vc4_hdmi_phy.c
> index 56e6a35da357..5040f014bf7e 100644
> --- a/drivers/gpu/drm/vc4/vc4_hdmi_phy.c
> +++ b/drivers/gpu/drm/vc4/vc4_hdmi_phy.c
> @@ -1197,4 +1197,9 @@ void vc6_hdmi_phy_init(struct vc4_hdmi *vc4_hdmi,
>   
>   void vc6_hdmi_phy_disable(struct vc4_hdmi *vc4_hdmi)
>   {
> +	unsigned long flags;
> +
> +	spin_lock_irqsave(&vc4_hdmi->hw_lock, flags);
> +	vc6_hdmi_reset_phy(vc4_hdmi);
> +	spin_unlock_irqrestore(&vc4_hdmi->hw_lock, flags);
>   }