Re: [PATCH v3 2/2] usb: typec: ucsi: add ITE885x I2C transport driver

[Edward Blair]

Hi Amber,

Thanks for reaching out, and apologies for the slow reply.

I'm happy to drop the separate transport driver in favour of
ucsi_itepd. Would you be willing to take the lead on adding the ACPI
support and any handling needed for these ASUS boards?

Please feel free to reuse anything useful from my patches. I can help
test your changes on my ASUS ROG Strix Z790-E Gaming WiFi with ITE8853
and provide logs or ACPI tables.

The MSFT8000 enumeration fix in patch 1 is separate from the transport
driver and has Armin's Reviewed-by and Rafael's Acked-by. That should
remain part of the solution for these boards.

Thanks,
Edward


On Sat, 24 Oct 2026 at 15:00, Edward Blair <edward.blair@xxxxxxxxx> wrote:
>
> Hi Amber,
>
> Thanks for reaching out, and apologies for the slow reply.
>
> I'm happy to drop the separate transport driver in favour of
> ucsi_itepd. Would you be willing to take the lead on adding the ACPI
> support and any handling needed for these ASUS boards?
>
> Please feel free to reuse anything useful from my patches. I can help
> test your changes on my ASUS ROG Strix Z790-E Gaming WiFi with ITE8853
> and provide logs or ACPI tables.
>
> The MSFT8000 enumeration fix in patch 1 is separate from the transport
> driver and has Armin's Reviewed-by and Rafael's Acked-by. That should
> remain part of the solution for these boards.
>
> Thanks,
> Edward
>
> On Fri, 2 Oct 2026 at 09:25, Amber Kao <ite_pd@xxxxxxxxxx> wrote:
>>
>> Hi Edward,
>>
>> On Sat, Aug 29, 2026 at 03:55:16PM +0100, Edward Blair wrote:
>> > Add a UCSI transport driver for ITE8853 and ITE8800 through ITE8805
>> > USB Type-C controllers found on desktop motherboards.
>>
>> Thanks for working on this. I'm from ITE, and I wanted to let you know
>> that we have been upstreaming a UCSI driver for the same controller
>> family. The driver was posted on 7 Aug 2026 and has Heikki's
>> Reviewed-by:
>>
>>   https://lore.kernel.org/linux-usb/20260807-ucsi-itepd-v7-0-998ac11ed0ef@xxxxxxxxxx/
>>
>> A follow-up series extending it to the IT885x and IT527x series has
>> also been acked:
>>
>>   https://lore.kernel.org/r/20260924-ucsi-itepd-it527x-v3-0-a7392aa087f5@xxxxxxxxxx
>>
>> Both drivers target the same register interface (CCI at 0x84,
>> MESSAGE_IN at 0x88, CONTROL at 0x98 and the vendor interrupt registers
>> at 0xbc/0xbd), so it would be better not to have two drivers for the
>> same hardware in drivers/usb/typec/ucsi.
>>
>> Our driver currently only matches through OF and I2C IDs, so it does
>> not yet cover the ACPI-enumerated ITE8853/ITE8800-ITE8805 devices on
>> the ASUS boards you are targeting. Would you be open to adding ACPI
>> support, and any platform-specific handling those boards need, on top
>> of ucsi_itepd instead of as a separate driver? We would be happy to
>> help with review.
>>
>> Heikki, Greg, please let us know how you would prefer to proceed.
>>
>> Thanks,
>> Amber Kao <ite_pd@xxxxxxxxxx>