Re: [PATCH] staging: sm750fb: clean up PLL calculation code

From: Greg KH

Date: Sat Oct 24 2026 - 10:11:15 EST


On Sat, Oct 24, 2026 at 05:20:41PM +0530, Himanshu Bakshi wrote:
> Hi Greg,

Please do not top-post or send html email, the list rejects that.

> I found this while reviewing sm750_calc_pll_value() and looking for a
> cleaner way to handle the PLL candidate calculation.

But why does it need to be "cleaner"?

> I tested the change as follows:
>
> Built the sm750fb driver successfully using make -j2
> M=drivers/staging/sm750fb W=1.
>
> Ran a standalone C differential regression test comparing the original
> and modified algorithms across 2,010,084 test cases, including
> frequency sweeps, boundary values, and randomized requests.

Ah, you used a LLM. You have read:
https://lore.kernel.org/r/2026080354-skater-urgent-31b2@gregkh
right?

Sorry,

greg k-h