Re: [PATCH v2 5/6] KEYS: Replace assoc_array with rhashtable
From: Jarkko Sakkinen
Date: Sat Oct 24 2026 - 12:30:13 EST
On Sat, Oct 24, 2026 at 05:28:39PM +0300, Jarkko Sakkinen wrote:
> kenter("{%d},,%zu", key_serial(keyring), buflen);
> @@ -512,20 +485,18 @@ static long keyring_read(const struct key *keyring,
> return -EINVAL;
This is another issue I have with the code that I recalled afters
sending the patch set.
Do we really want to retain kenter or kleave? I don't see any point
as kprobes and kretprobes have literally existed for decades already.
I propose removing them from add/modified functions in this patch
set or alternatively prepend this with a commit that deletes them
entirely from the subsystem (I like the latter better actually).
Br, Jarkko