Re: [PATCH v2 3/7] regulator: qcom-pm8008: Add PM8010 mode support

[Guru Das Srinagesh]

On Thu, Oct 22, 2026 at 02:12:50PM +0530, Jishnu Prakash wrote:
> Hi Guru,
> 
> On 10/19/2026 1:11 PM, Guru Das Srinagesh wrote:
> > On Wed, Oct 14, 2026 at 04:02:00PM +0530, Jishnu Prakash wrote:
> >> From: Dhruvin Rajpura <drajpura@xxxxxxxxxxxxxxxx>
> >>
> >> Implement set_mode/get_mode support for PM8010 LDOs using the mode
> >> control and status registers to allow clients to vote for LDO modes.
> >> Mode voting is not supported in the PM8008 LDOs.
> >>
> >> Signed-off-by: Dhruvin Rajpura <drajpura@xxxxxxxxxxxxxxxx>
> >> Tested-by: Oleg Keri <okerixx@xxxxxxxxx> # Lenovo Yoga Slim 7x Gen 11 (Glymur)
> >> Signed-off-by: Jishnu Prakash <jishnu.prakash@xxxxxxxxxxxxxxxx>
> >> ---
> >>  drivers/regulator/qcom-pm8008-regulator.c | 75 ++++++++++++++++++++++++++++++-
> >>  1 file changed, 74 insertions(+), 1 deletion(-)
> > 
> > ...
> > 
> > Patches 2 and 3 both say "Add PM8010 mode support" in their subject lines and edit
> > the same file. Could they either be squashed into one commit or have their subject
> > lines amended appropriately to better reflect the changes they are making?
> > 
> 
> The difference is just one word, patch 2's subject is "Add PM8010 support".

Indeed, sorry for the oversight.

> To distinguish them, I'll update patch 3's subject to "Add mode voting support
> for PM8010", I hope this is fine.

Yes, this is fine by me.