[PATCH] ASoC: qdsp6: q6routing: Fix memory leak on probe failure

[Tang Bin]

routing_data is allocated with kzalloc() (not devm_kzalloc) and stored
in a global static pointer. If devm_snd_soc_register_component() fails,
the probe function returns the error directly without freeing
routing_data. Since the remove callback is not invoked on probe failure,
the allocated memory is leaked.

On a probe retry, a new routing_data would be allocated, overwriting
the global pointer and losing the reference to the previous allocation.

Fix this by checking the return value of
devm_snd_soc_register_component() and freeing routing_data on failure.

Fixes: e3a33673e845 ("ASoC: qdsp6: q6routing: Add q6routing driver")
Signed-off-by: Tang Bin <tangbin@xxxxxxxxxxxxxxxxxxxx>
---
 sound/soc/qcom/qdsp6/q6routing.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/sound/soc/qcom/qdsp6/q6routing.c b/sound/soc/qcom/qdsp6/q6routing.c
index d076c99f1..fb633efd8 100644
--- a/sound/soc/qcom/qdsp6/q6routing.c
+++ b/sound/soc/qcom/qdsp6/q6routing.c
@@ -1208,6 +1208,7 @@ static const struct snd_soc_component_driver msm_soc_routing_component = {
 static int q6pcm_routing_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
+	int ret;
 
 	routing_data = kzalloc_obj(*routing_data);
 	if (!routing_data)
@@ -1218,8 +1219,13 @@ static int q6pcm_routing_probe(struct platform_device *pdev)
 	mutex_init(&routing_data->lock);
 	dev_set_drvdata(dev, routing_data);
 
-	return devm_snd_soc_register_component(dev, &msm_soc_routing_component,
+	ret = devm_snd_soc_register_component(dev, &msm_soc_routing_component,
 					  NULL, 0);
+	if (ret) {
+		kfree(routing_data);
+		routing_data = NULL;
+	}
+	return ret;
 }
 
 static void q6pcm_routing_remove(struct platform_device *pdev)
-- 
2.52.0.windows.1