Re: [PATCH v2] MIPS: Cobalt: Include legacy IDE ports in the PCI I/O window

From: Florian Fainelli

Date: Sun Oct 25 2026 - 15:16:34 EST




On 10/24/2026 7:55 PM, Maciej W. Rozycki wrote:
On Thu, 22 Oct 2026, Florian Fainelli wrote:

Changes in v2:

- implement Maciej's suggestion to reserve PCI resources first
and then the rest of the peripherals

Thanks.

diff --git a/arch/mips/cobalt/pci.c b/arch/mips/cobalt/pci.c
index 85ec9cc31d66..29fd052766b2 100644
--- a/arch/mips/cobalt/pci.c
+++ b/arch/mips/cobalt/pci.c
@@ -14,6 +14,8 @@
#include <asm/gt64120.h>
+#include <cobalt.h>
+

Hmm, why do you need it here now, a leftover from testing?

Yes indeed it was a leftover from moving code around until I settled on the current approach.


With that removed, unless proved otherwise:

Reviewed-by: Maciej W. Rozycki <macro@xxxxxxxxxxx>

Thanks v3 incoming.
--
Florian