Re: [PATCH] ASoC: tas2770: Only treat negative return codes as errors set_tdm_idle

From: Mark Brown

Date: Sun Oct 25 2026 - 16:40:38 EST


On Sat, Oct 24, 2026 at 01:30:12PM +0200, Markus Elfring wrote:
> > snd_soc_component_update_bits returns 1 on a successful update, and
> > we were returning from tas2770_set_dai_tdm_idle early on any nonzero
> > return code. Change this so that only negative return codes are
> > treated as errors.
>
> https://elixir.bootlin.com/linux/v7.3/source/sound/soc/codecs/tas2770.c#L495-L567
>
> * How do you think about to refine the summary phrase another bit
> like “Fix error detection in tas2770_set_dai_tdm_idle()”?

Feel free to ignore Markus, he has a long history of sending
unhelpful review comments and continues to ignore repeated requests
to stop.

Attachment: signature.asc
Description: PGP signature