Re: [PATCH 3/4] clk: ingenic: jz4760-cgu: Adapt calc_m_n_od() to core framework changes

[Paul Cercueil]

Hi Nikolaus,

Le dimanche 25 octobre 2026 à 20:18 +0100, H. Nikolaus Schaller a
écrit :
> The common Ingenic CGU core framework was updated to support a
> secondary post-VCO divider (OD1), which extended the signature of the
> calc_m_n_od() callback.
> 
> Update the JZ4760 CGU driver implementation to accept the new pod1
> argument, preventing compilation errors. The parameter remains unused
> on this specific SoC architecture.
> 
> Signed-off-by: H. Nikolaus Schaller <hns@xxxxxxxxxxxxx>
> ---
>  drivers/clk/ingenic/jz4760-cgu.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/ingenic/jz4760-cgu.c
> b/drivers/clk/ingenic/jz4760-cgu.c
> index 372fe4b079927..52cc5ce150048 100644
> --- a/drivers/clk/ingenic/jz4760-cgu.c
> +++ b/drivers/clk/ingenic/jz4760-cgu.c
> @@ -56,7 +56,8 @@ static const u8 jz4760_cgu_pll_half_div_table[] = {
>  static void
>  jz4760_cgu_calc_m_n_od(const struct ingenic_cgu_pll_info *pll_info,
>  		       unsigned long rate, unsigned long
> parent_rate,
> -		       unsigned int *pm, unsigned int *pn, unsigned
> int *pod)
> +		       unsigned int *pm, unsigned int *pn, unsigned
> int *pod,
> +		       unsigned int *pod1)
>  {
>  	unsigned int m, n, od, m_max = (1 << pll_info->m_bits) - 1;
>  

Well you can't update a callback prototype in patch 2/4 then update the
implementations in 3/4, the kernel has to be buildable after each
patch.

Cheers,
-Paul