Re: [PATCH net 2/2] net: dsa: mv88e6xxx: fix 88E6171 statistics type

[Andrew Lunn]

On Sat, Oct 24, 2026 at 11:21:24AM -0700, Florian Fainelli wrote:
> The 88E6171 uses the 6095 statistics operations, which advertise and name
> BANK0 and PORT counters. Its stats_type bitmap instead selects BANK0 and
> BANK1. Since statistics collection started using that bitmap, it has
> written a different set of counters from the one advertised to ethtool.
> 
> For this chip, get_sset_count() accounts for 30 BANK0 counters, three
> PORT counters and five ATU/VTU counters. Collection instead writes 30
> BANK0 counters, 26 BANK1 counters and five ATU/VTU counters: 61 entries
> rather than the advertised 38. This mislabels the tail of the returned
> statistics and writes past the advertised statistics buffer.
> 
> Select BANK0 and PORT counters to match the chip's statistics operations
> and restore the filter used before the bitmap was introduced. Tested on
> an EA4500, where the two-bridge forwarding and multicast snooping tests
> now pass their hardware counter checks.
> 
> Fixes: 5595e3613ea7 ("dsa: mv88e6xxx: Move available stats into info structure")
> Signed-off-by: Florian Fainelli <f.fainelli@xxxxxxxxx>

Reviewed-by: Andrew Lunn <andrew@xxxxxxx>

    Andrew