Re: [PATCH v2 15/17] iio: light: rpr0521: Discard pm_runtime_put_autosuspend() return values

From: Jonathan Cameron

Date: Sun Oct 25 2026 - 20:59:11 EST


On Wed, 21 Oct 2026 16:57:16 -0700
Brian Norris <briannorris@xxxxxxxxxxxx> wrote:

> This driver propagates the return value of pm_runtime_put_autosuspend(),
> which is not particularly useful.
>
> Returning an error code from pm_runtime_put_autosuspend() merely means
> that it has not queued up a timer or work item to check whether or not
> the device can be suspended and there are many perfectly valid
> situations in which that can happen, like after writing "on" to the
> device's runtime PM "control" attribute in sysfs for one example.
>
> For this reason, modify this driver to simply discard the
> pm_runtime_put_autosuspend() return value.
>
> This will facilitate a planned change of the
> pm_runtime_put_autosuspend() return type to void in the future, similar
> to commit 3afd8df02433 ("PM: runtime: Change pm_runtime_put() return
> type to void").
>
> Signed-off-by: Brian Norris <briannorris@xxxxxxxxxxxx>
This one is complex. However I don't see low hanging fruit for
taking the cleanup further. As such I'm going to pick this
one up now. Maybe someone will look at this in the near future
but this particular one isn't going to be me!

Applied to the testing branch of iio.git

Thanks,

Jonathan