Re: [PATCH v2 2/2] selftests: liveupdate: Add tests for LIVEUPDATE_SESSION_FREEZE

[Pasha Tatashin]

On Fri, Oct 23, 2026 at 3:30 AM Mike Rapoport <rppt@xxxxxxxxxx> wrote:
>
> On Tue, Oct 20, 2026 at 10:47:04AM -0400, Pasha Tatashin wrote:
> > Provide luo_session_freeze() in the liveupdate test library and add unit
> > tests in liveupdate.c covering the LIVEUPDATE_SESSION_FREEZE ioctl. The
> > tests verify that non-zero reserved bits are rejected with -EINVAL, an
> > outgoing session with preserved files can be frozen early, freezing an
> > already frozen session returns -EBUSY, and attempting to preserve an
> > additional file descriptor into a frozen session fails with -EBUSY.
>
> Please teach your LLM to use shorter paragraphs :)

For selftests, I usually let it express itself :-)))

>
> Do we need the entire list of what the test checks in the changelog?

Will fix.

>
> > Also freeze the test session early in luo_kexec_simple.c to exercise
> > LIVEUPDATE_SESSION_FREEZE across a kexec reboot, and verify that
> > attempting to freeze a retrieved incoming session returns -EINVAL.
> >
> > Signed-off-by: Pasha Tatashin <pasha.tatashin@xxxxxxxxxx>
> > ---
> >  .../liveupdate/lib/include/libliveupdate.h    |  1 +
> >  .../selftests/liveupdate/lib/lu_utils.c       | 10 ++++
> >  .../testing/selftests/liveupdate/liveupdate.c | 49 +++++++++++++++++++
> >  .../selftests/liveupdate/luo_kexec_simple.c   |  8 +++
> >  4 files changed, 68 insertions(+)
>
> --
> Sincerely yours,
> Mike.