Re: [PATCH v8 00/20] crypto: talitos - Driver cleanup

[Herbert Xu]

On Tue, Oct 13, 2026 at 03:11:26PM +0200, Paul Louvel wrote:
> The Freescale Integrated Security Engine (SEC) aka "Talitos" driver
> implementation is a monolithic ~3800-line file that mixes SEC1 and SEC2
> hardware variants with hash, skcipher, aead and hwrng algorithm.
> 
> This series reorganises the driver to improve readability and
> maintainability:
> 
> - Split the driver into a dedicated directory with separate files for
>   hash, skcipher, aead, and hwrng implementations.
> 
> - Modernise the crypto API usage: adopt {init,exit}_tfm (deprecated
>   cra_init/cra_exit), use CRYPTO_AHASH_ALG_BLOCK_ONLY to eliminate
>   manual partial-block buffering, and use macros to deduplicate
>   algorithm definitions.
> 
> - Introduce a is_sec1() helper to get rid of is_sec1 variables /
>   parameters.
> 
> - Define descriptor/pointer structures for each hardware version,
>   instead of using a single structure and anonymous union.
> 
> No functional changes are intended except for patch 1.
> 
> This series depends on the "crypto: talitos - bug fixes" series :
> https://patch.msgid.link/20260507-bootlin_test-7-1-rc1_sec_bugfix-v3-0-c98d7589b942@xxxxxxxxxxx
> 
> Signed-off-by: Paul Louvel <paul.louvel@xxxxxxxxxxx>
> ---
> Changes in v8:
> - Patch 1: not addressing this Sashiko issue.
>   I had no problem while testing, and [0] "When this flag is cleared to
>   manually pad the message, it appears to completely disable the
>   hardware's HMAC outer hash (opad) execution." is an hallucination.
>   There is no such statement in the reference manual, nor the
>   programming manual (AN2912).

Well, Sashiko now has another comment to the same patch.

I think this series is too big.  Let's break it into smaller pieces.
For instance, let's just focus on the first patch for now without
the rest.

Thanks,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt