Re: [PATCH] staging: greybus: audio_manager_module: add missing newline to sysfs_emit()
From: Dan Carpenter
Date: Mon Oct 26 2026 - 01:52:31 EST
On Sun, Oct 25, 2026 at 10:54:27PM +0200, Anghel Mihai-Alexandru wrote:
> Documentation/filesystems/sysfs.rst recommends that single-value sysfs
> attributes end with a newline, consistent with other Greybus sysfs
> show() callbacks (see e.g. loopback.c). The name/vid/pid/intf_id/
> ip_devices/op_devices attributes were missing it.
>
> No functional change.
It absolutely is a functional change and that's why we have rejected
it a dozen times already. :P
regards,
dan carpenter