Re: [PATCH 2/2] dt-bindings: display: sitronix,st75156: add example for SPI

From: Krzysztof Kozlowski

Date: Mon Oct 26 2026 - 03:22:39 EST


On Thu, Oct 22, 2026 at 05:31:06PM +0200, Lars Rask wrote:
> From: Lars Rask <lars.rask@xxxxxxxx>
>
> Add example for using st75156 with SPI.

Your patch does not add example but entire binding. Please describe your
patches appropriately.

>
> Signed-off-by: Lars Rask <lars.rask@xxxxxxxx>
> ---
> .../bindings/display/sitronix,st75156.yaml | 67 ++++++++++++++++++++++
> MAINTAINERS | 1 +
> 2 files changed, 68 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/sitronix,st75156.yaml b/Documentation/devicetree/bindings/display/sitronix,st75156.yaml
> new file mode 100644
> index 000000000000..a3897ddc5e38
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/sitronix,st75156.yaml
> @@ -0,0 +1,67 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/sitronix,st75156.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sitronix ST75156 Display Controller
> +
> +maintainers:
> + - Marcus Folkesson <marcus.folkesson@xxxxxxxxx>
> +
> +description:
> + Sitronix ST75156 is a monochrome dot matrix LCD panel used in SPI 4-wire mode.
> +
> +allOf:
> + - $ref: panel/panel-common.yaml#
> +
> +properties:
> + compatible:
> + const: sitronix,st75156
> +

Everything looks the same as sitronix,st7571, so why this cannot be
added there?

Best regards,
Krzysztof