Re: [PATCH net] net: dsa: motorcomm: Report error when FDB fails to add

[David Yang]

On Mon, Oct 26, 2026 at 8:44 AM Andrew Lunn <andrew@xxxxxxx> wrote:
>
> On Sun, Oct 25, 2026 at 10:41:11AM +0800, David Yang wrote:
> > fdb_add() ignored any errors returned by the hardware (for example,
> > table is full). Return error for that case.
> >
> > Fixes: 186623f4aa72 ("net: dsa: yt921x: Add support for Motorcomm YT921x")
> > Signed-off-by: David Yang <mmyangfl@xxxxxxxxx>
>
> I'm not sure this deserves a Fixes tag. How many entries does the
> table take before it is full? Typical home networks have what, 10, 20
> devices maximum. A small business network may have a couple of
> hundred?
>
> What happens if it is full, and you don't return ENOSPC?
>
>       Andrew

When full, the error was silently ignored -- the bridge kept the entry
marked offloaded while the hardware never stored it.

May indeed be too minor for a Fixes tag -- could drop it in v2 if you prefer.