Re: [PATCH v5 07/10] drm/msm/dpu: clear the DSPP pointer when no DSPP is assigned

From: Konrad Dybcio

Date: Mon Oct 26 2026 - 05:16:15 EST


On 10/24/26 1:25 AM, Dmitry Baryshkov wrote:
> dpu_crtc_assign_resources() only stores mixers[i].hw_dspp when the new
> topology has a DSPP for that mixer, and dpu_crtc_duplicate_state() copies
> the state with kmemdup(), so a crtc which once used a DSPP keeps a pointer
> to it for the rest of its life -- across reservations which no longer own
> that block.
>
> Assign NULL when there is no DSPP for the mixer.
>
> Fixes: 4259ff7ae509 ("drm/msm/dpu: add support for pcc color block in dpu driver")
> Assisted-by: LLM
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@xxxxxxxxxxxxxxxx>
> ---

Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxxxx>

Konrad