Re: [PATCH v2 6/6] media: qcom: camss: sm8250: set the camera NoC AXI rate from the VFE

[Bryan O'Donoghue]

On 24/10/2026 10:40, Atanas Filipov wrote:
> The SM8250 VFE resources list both the camera NoC AXI RCG,
> camnoc_axi_src, and its camnoc_axi branch. The camnoc_axi_src levels
> are never applied, since vfe_match_clock_names() does not match that
> name, and they list 480 MHz, which the RCG does not support. The
> camnoc_axi branch has no rates, so the camera NoC runs from XO and two
> concurrent streams stall.
> 
> Drop camnoc_axi_src, as the camnoc_axi branch keeps it enabled through
> its parent, and list the 300 and 400 MHz camera NoC AXI rates for the
> camnoc_axi branch, whose rate the VFE sets through the parent. The four
> VFEs share its source through a clock domain, so it runs at the highest
> rate requested by the running VFEs.
> 
> Signed-off-by: Atanas Filipov<atanas.filipov@xxxxxxxxxxxxxxxx>

I suggested bundling in clk_set_rate_range() to this patch but I believe 
it would be more productively and correctly done as a wholesale 
replacement of patch #4.

The point of your patch#4 was to fix the framework, which should be done 
I agree as a standalone patch - not mushed in here.

---
bod