Re: [PATCH net] net: rnpgbe: Accept link-down events without speed magic
From: Yibo Dong
Date: Mon Oct 26 2026 - 05:28:53 EST
On Mon, Oct 26, 2026 at 08:00:22AM +0000, netdev-bot+sinfo@xxxxxxxxxx wrote:
> Hi!
>
> This is an automated message. This series looks like a fix, but its
> commit messages seem to be missing some information:
>
> - How the issue was discovered, e.g. hit in production, hit during
> development, syzbot report, manual code inspection, LLM or static
> analysis tool scan.
>
> - What hardware the change was tested on. For driver fixes please
> mention the device (and if relevant firmware version) used for
> testing, or say that the change was not tested on real hardware.
>
> Please do not repost the series just to address the above. Instead,
> reply to this email with the missing information, so that reviewers
> can take it into account. If the series needs another revision for
> other reasons, please include the information in the commit messages
> then.
>
> The evaluation is done by an LLM so it may be wrong, if you think
> that is the case please reply and explain.
>
Hi,
The issue was encountered during rnpgbe development and hardware
regression testing.
The fix was tested on MUCSE N210 and N500 adapters with firmware
1.1.8.0, using PCI passthrough to a VM. Physical N500 is used as
link partners.
With the unpatched driver, administratively bringing down the link
partner left the VM interface reporting carrier up throughout a
seven-second observation period. With the patch applied, the VM
interface correctly reported carrier down.
The comparison was repeated three times per adapter for both driver
versions. After bringing the link partner back up, bidirectional
ping passed in every case.
If another revision is needed, I will include this information in
the commit message.
Thanks,
Dong Yibo