Re: [PATCH 1/7] dt-bindings: mfd: x-powers,axp152: Add the AXP2101

[Krzysztof Kozlowski]

On 26/10/2026 10:30, Krzysztof Kozlowski wrote:
> On Fri, Oct 23, 2026 at 12:03:55PM +0200, Olivier Louvignes wrote:
>> The AXP2101's interrupt line is optional, as for the AXP313A and the
>> AXP15060: the driver then registers only the regulators. It has no DCDC
>> frequency setting.
>>
>> Signed-off-by: Olivier Louvignes <olivier@xxxxxxxxx>
>> ---
>>  Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml | 3 +++
>>  1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml
>> index 45f015d63df1..f5e2c8232581 100644
>> --- a/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml
>> +++ b/Documentation/devicetree/bindings/mfd/x-powers,axp152.yaml
>> @@ -68,6 +68,7 @@ allOf:
>>            compatible:
>>              contains:
>>                enum:
>> +                - x-powers,axp2101
> 
> Why breaking the order? Keep natural sorted.
> 
>>                  - x-powers,axp15060
>>                  - x-powers,axp305
>>                  - x-powers,axp313a
>> @@ -84,6 +85,7 @@ allOf:
>>              enum:
>>                - x-powers,axp313a
>>                - x-powers,axp323
>> +              - x-powers,axp2101
> 
> Sorting is broken in original code but you placed it completely odd.
> Neither keeping sorting of 3xx variants nor, between 15060 and 717.
> What's the logic?
> 
>>                - x-powers,axp15060
>>                - x-powers,axp717
>>  
>> @@ -108,6 +110,7 @@ properties:
>>            - x-powers,axp806
>>            - x-powers,axp809
>>            - x-powers,axp813
>> +          - x-powers,axp2101
> 
> Placement of these entries makes no sense.

Ah, this one is actually sorted by natural sort.

Best regards,
Krzysztof