Re: [PATCH v3 1/2] dt-bindings: usb: Add Samsung Exynos8855 DWC3 controller binding
From: Krzysztof Kozlowski
Date: Mon Oct 26 2026 - 05:50:56 EST
On Fri, Oct 23, 2026 at 06:45:00PM +0530, Selvarasu Ganesan wrote:
> +title: Samsung Exynos8855 DWC3 USB controller
> +
> +maintainers:
> + - Krzysztof Kozlowski <krzk@xxxxxxxxxx>
> + - Selvarasu Ganesan <selvarasu.g@xxxxxxxxxxx>
> +
> +description:
> + Describes the DWC3 USB controller block implemented on the Samsung
> + Exynos8855 SoC.
> +
> +properties:
> + compatible:
> + enum:
> + - samsung,exynos8855-dwc3
> +
> + reg:
> + maxItems: 1
> +
> + power-domains:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
interrupts go after clocks, power-domains after interrupts.
> +
> + clocks:
> + description: |
> + Two clocks are used:
> + - ref: Reference clock for SOF/ITP generation.
> + - bus: Bus (APB) clock for register access.
> + minItems: 2
> + maxItems: 2
Instead replace all this with listing items with description. Don't
repeat constraints in free form text.
items:
- description:
- description:
> +
> + clock-names:
> + items:
> + - const: ref
> + - const: bus
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> + - clock-names
> + - interrupts
Here you have correct order.
Best regards,
Krzysztof