Re: [PATCH v2 2/2] dt-bindings: i2c: ingenic,i2c: Add the X1600
From: Andi Shyti
Date: Mon Oct 26 2026 - 06:01:21 EST
Hi,
On Mon, Oct 26, 2026 at 09:06:43AM +0100, Krzysztof Kozlowski wrote:
> On 24/10/2026 23:25, Olivier Louvignes wrote:
> > The X1600's I2C controller has the X1000's registers, so it falls back
> > to ingenic,x1000-i2c.
> >
> > Signed-off-by: Olivier Louvignes <olivier@xxxxxxxxx>
>
> Why changing order of patches? Previous was correct one.
>
>
> Please organize the patch documenting the compatible (DT bindings)
> before the patch using that compatible.
> See also:
> https://elixir.bootlin.com/linux/v6.14-rc6/source/Documentation/devicetree/bindings/submitting-patches.rst#L46
I can swap the patches before applying if they are OK. Next time,
please, follow Krzysztof's instructions.
I'll wait for Nikolaus ack/r-b for applying the patches.
Thanks,
Andi
> With this fixed:
>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxxxxxxxx>
>
> Best regards,
> Krzysztof