Re: [PATCH v2 1/2] dt-bindings: interconnect: qcom: Add SM7250 RPMh NoC bindings

[Krzysztof Kozlowski]

On Sat, Oct 24, 2026 at 08:40:53AM +0530, Ishu Brar wrote:
> Document the Network-On-Chip interconnect providers of the Qualcomm
> SM7250 SoC (Snapdragon 765/765G/768G), which are controlled through RPMh
> Bus Clock Managers, and add the header with the node and slave IDs.

A nit, subject: drop second/last, redundant "bindings". The
"dt-bindings" prefix is already stating that these are bindings.
See also:
https://elixir.bootlin.com/linux/v7.1-rc7/source/Documentation/devicetree/bindings/submitting-patches.rst#L23

> 
> Signed-off-by: Ishu Brar <patches@xxxxxxx>
> ---
>  .../bindings/interconnect/qcom,sm7250-rpmh.yaml    |  95 +++++++++++++
>  .../dt-bindings/interconnect/qcom,sm7250-rpmh.h    | 148 +++++++++++++++++++++
>  2 files changed, 243 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/interconnect/qcom,sm7250-rpmh.yaml b/Documentation/devicetree/bindings/interconnect/qcom,sm7250-rpmh.yaml
> new file mode 100644
> index 000000000..f8891faa8
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interconnect/qcom,sm7250-rpmh.yaml
> @@ -0,0 +1,95 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/interconnect/qcom,sm7250-rpmh.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Qualcomm RPMh Network-On-Chip Interconnect on SM7250
> +
> +maintainers:
> +  - Ishu Brar <patches@xxxxxxx>
> +
> +description: |
> +  RPMh interconnect providers support system bandwidth requirements through
> +  RPMh hardware accelerators known as Bus Clock Manager (BCM). The provider is
> +  able to communicate with the BCM through the Resource State Coordinator (RSC)
> +  associated with each execution environment. Provider nodes must point to at
> +  least one RPMh device child node pertaining to their RSC and each provider
> +  can map to multiple RPMh resources.
> +
> +  See also: include/dt-bindings/interconnect/qcom,sm7250-rpmh.h
> +
> +properties:
> +  compatible:
> +    enum:
> +      - qcom,sm7250-aggre1-noc
> +      - qcom,sm7250-aggre2-noc
> +      - qcom,sm7250-config-noc
> +      - qcom,sm7250-dc-noc
> +      - qcom,sm7250-gem-noc
> +      - qcom,sm7250-mmss-noc
> +      - qcom,sm7250-npu-noc
> +      - qcom,sm7250-system-noc
> +
> +  reg:
> +    maxItems: 1
> +
> +# Child node's properties

Drop comment

> +patternProperties:
> +  '^interconnect-[a-z0-9\-]+$':

Why this has to be a pattern, not 'interconnect'? And anyway, pattern is
'^interconnect-[0-9]+$' if you have multiple children.


Best regards,
Krzysztof