Re: [PATCH] media: i2c: ov5693: Support control events

[Sakari Ailus]

Hi Simon,

On Sat, Oct 10, 2026 at 02:20:54PM +0000, Simon Kruse wrote:
> The sensor subdev exposes controls but does not implement the control
> event operations, so VIDIOC_SUBSCRIBE_EVENT fails and v4l2-compliance
> reports:
> 
>   fail: v4l2-test-controls.cpp(1128): subscribe event for control 'User Controls' failed
>   test VIDIOC_(UN)SUBSCRIBE_EVENT/DQEVENT: FAIL
> 
> Add the standard control event subdev operations and set
> V4L2_SUBDEV_FL_HAS_EVENTS.
> 
> Signed-off-by: Simon Kruse <simon0x+git@xxxxxxxxx>

Could you instead move the driver to use sub-device state? See an example
in commit e8a5b1df000e1a23c04dadbe99621441e0889f88 . You'll get control
events as a bonus. :-)

-- 
Regards,

Sakari Ailus