Re: [PATCH net-next 2/3] net: qrtr: propagate sock_alloc_send_skb() errors from sendmsg()

[Manivannan Sadhasivam]

On Fri, Oct 16, 2026 at 01:58:19AM -0700, Chunkai Deng wrote:
> Since commit 179d0ba0c454 ("net: qrtr: fix error return code of
> qrtr_sendmsg()"), qrtr_sendmsg() returns -ENOMEM whenever
> sock_alloc_send_skb() fails. The helper already sets rc on every failure
> path, so this overwrites the real error.
> 
> In particular, sock_alloc_send_skb() consumes a pending sk_err, so the
> ENETRESET set by qrtr_reset_ports() is lost and userspace never learns
> that a new controller came up. -EAGAIN, -EPIPE and signal errors are
> hidden as well.
> 
> Return the error from sock_alloc_send_skb() as is.
> 
> Signed-off-by: Chunkai Deng <chunkai.deng@xxxxxxxxxxxxxxxx>

Since this patch fixes an issue, it should have the Fixes tag and stable list
should be CCed for backporting. With these added:

Reviewed-by: Manivannan Sadhasivam <manivannan.sadhasivam@xxxxxxxxxxxxxxxx>

- Mani

-- 
மணிவண்ணன் சதாசிவம்