Re: [RFC PATCH v2 07/74] Add support for FDT_PROPDATA_PHANDLE dtb tag
From: Herve Codina
Date: Mon Oct 26 2026 - 09:25:16 EST
Hi David,
On Mon, 26 Oct 2026 12:30:31 +1100
David Gibson <david@xxxxxxxxxxxxxxxxxxxxx> wrote:
...
> > Ok I've looked deeper to remove the is_local field. It should be doable.
> >
> > complete_references(), probably renamed to fixup_references(), will still be
> > needed
>
> Right, I'd expect that.
>
> > and called from build_dt_info().
>
> This I'm less certain about, since the function needs to fix up in
> opposite directions depending on the input mode. But, I'll look at
> the patch once it's posted.
At least, the next iteration gives me a chance to convince you.
Again, the idea is to have all references set to correct values when we return
from build_dt_info(). In other words, "transitional" states do not exist after
the build_dt_info() call.
With the code updated in the next iteration, this point will be easier to grasp
and so to discuss if needed.
Best regards,
Hervé