Re: [PATCH v4 0/4] ARM: s3c: crag6410: Convert to software nodes and properties

[Arnd Bergmann]

On Sun, Oct 25, 2026, at 06:03, Dmitry Torokhov wrote:
> Hi,
>
> This series converts the Cragganmore 6410 board to generic software nodes
> and device properties, allowing the removal of legacy GPIO lookup tables.
>
> We add software node propagation support to the wm831x MFD core to route
> DVS GPIOs to the PMIC regulator, and convert the peripherals on the
> Cragganmore board (PMIC DVS GPIO, basic-mmio-gpio, LEDs, WM1250, and SPI0)
> from legacy GPIO lookup tables to software nodes and properties. This
> eliminates the legacy GPIO lookup tables on the board and fixes incorrect
> GPIO chip names from previous conversions.
>
> Hopefully Krzysztof can finish merging the series through the soc tree
> once Lee acks the MFD part.

Hi Dmitry,

This all looks good to me,

Acked-by: Arnd Bergmann <arnd@xxxxxxxx>

I'm a bit unsure about how this fits into your wider plan, i.e. why it
is helpful to replace the lookup tables with device properties in
this file:
Are you working towards eliminating all gpio lookup tables from
the ~50 files currently defining them, or is there an immediate
benefit to doing this one in particular even without the others?

Do you plan to also eliminate the uses of the legacy gpio
interfaces in mach-s3c, e.g. the hardcoded numbers
in {pca953x,wm831x}_platform_data, crag6410_lcd_power_set(),
crag6410_machine_init(), or the pin config in
s3c64xx_i2s_cfg_gpio()?

     Arnd