Re: [PATCH v1] media: rppx1: wbmeas: Fix uapi documentation

[Niklas Söderlund]

Hi Barnabás,

Thanks for your work.

On 2026-10-26 15:02:15 +0100, Barnabás Pőcze wrote:
> The format is Q4.12 as already mentioned earlier in the documentation.
> 
> Fixes: 884d6794a816 ("media: rppx1: wbmeas: Add support for white balance measurement")
> Signed-off-by: Barnabás Pőcze <barnabas.pocze+renesas@xxxxxxxxxxxxxxxx>

Nice catch.

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@xxxxxxxxxxxx>

> ---
>  include/uapi/linux/media/dreamchip/rppx1-config.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/uapi/linux/media/dreamchip/rppx1-config.h b/include/uapi/linux/media/dreamchip/rppx1-config.h
> index 3507a9ab03dfd..f7c5a88922444 100644
> --- a/include/uapi/linux/media/dreamchip/rppx1-config.h
> +++ b/include/uapi/linux/media/dreamchip/rppx1-config.h
> @@ -154,7 +154,7 @@ enum rppx1_wbmeas_mode {
>   *	   @ymax_cmp is set to enabled, 24 bits
>   * @max_csum: chrominance sum maximum value, 24 bits
>   * @min_c: chrominance minimum value, 24 bits
> - * @ccor_coeff: coefficients for color conversion matrix, signed 16 bits Q4.6
> + * @ccor_coeff: coefficients for color conversion matrix, signed 16 bits Q4.12
>   * @reserved2: padding
>   * @ccor_offs: R-G-B color conversion coefficients, signed 25 bits 2's complement
>   * @reserved3: padding
> -- 
> 2.56.0
> 

-- 
Kind Regards,
Niklas Söderlund