Re: [PATCH v2 0/3] iio: proximity: sx93xx: keep the IRQ balanced across suspend and resume
From: Joshua Crofts
Date: Mon Oct 26 2026 - 10:22:05 EST
On Mon, 26 Oct 2026 16:53:03 +0530
Arnav Kapoor <kapoorarnav43@xxxxxxxxx> wrote:
> sx9310, sx9324 and sx9360 disable the interrupt in suspend before
> anything that can fail, and don't enable it again when suspend or resume
> fails. Without an interrupt line they also act on IRQ 0. One patch per
> driver, as the Fixes tags differ.
>
> Changes in v2:
> - Send as a series with a cover letter (Joshua)
> - sx9310: move the wake-up register writes into a helper that uses
> guard(), so resume can use the usual early returns (Andy)
> - sx9324, sx9360: no changes
>
> v1:
> https://lore.kernel.org/all/20261026100322.16720-1-kapoorarnav43@xxxxxxxxx/
> https://lore.kernel.org/all/20261026100408.16874-1-kapoorarnav43@xxxxxxxxx/
> https://lore.kernel.org/all/20261026100450.17023-1-kapoorarnav43@xxxxxxxxx/
>
> Compile-tested only (W=1); I don't have the hardware and haven't
> reproduced a failing suspend.
The code seems good, would be great if someone could test this.
Reviewed-by: Joshua Crofts <joshua.crofts1@xxxxxxxxx>
--
Kind regards,
Joshua Crofts