Re: [PATCH 2/8] Docs/admin-guide/mm/damon/stat: fix pronoun agreement
From: SJ Park
Date: Mon Oct 26 2026 - 10:35:21 EST
On Mon, 26 Oct 2026 13:44:55 +0100 Manuel Ebner <manuelebnerli@xxxxxxxxxxx> wrote:
> Hi Aveline,
>
> On Mon, 2026-10-26 at 22:14 +1100, Aveline Noir wrote:
> > "converts it" refers to the access events, so I think it should be
> > "them". Rewrap the paragraph while at it.
> >
> > Signed-off-by: Aveline Noir <jm5905938@xxxxxxxxx>
> > ---
> > Documentation/admin-guide/mm/damon/stat.rst | 8 ++++----
> > 1 file changed, 4 insertions(+), 4 deletions(-)
> >
> > diff --git a/Documentation/admin-guide/mm/damon/stat.rst b/Documentation/admin-guide/mm/damon/stat.rst
> > index 4a9db755a526..a93609649a5f 100644
> > --- a/Documentation/admin-guide/mm/damon/stat.rst
> > +++ b/Documentation/admin-guide/mm/damon/stat.rst
>
> Here I found this one:
> @@ -41,8 +41,8 @@ enabled
>
> Enable or disable DAMON_STAT.
>
> -You can enable DAMON_STAT by setting the value of this parameter as ``Y``.
> -Setting it as ``N`` disables DAMON_STAT. The default value is set by
> +You can enable DAMON_STAT by setting the value of this parameter to ``Y``.
> +Setting it to ``N`` disables DAMON_STAT. The default value is set by
> ``CONFIG_DAMON_STAT_ENABLED_DEFAULT`` build config option.
Thanks. Unless Aveline objects or add this part to the next revision of this
patch, I will add this when I apply this patch to damon/next.
>
> > @@ -68,10 +68,10 @@ estimated_memory_bandwidth
> > Estimated memory bandwidth consumption (bytes per second) of the system.
> >
> > DAMON_STAT reads observed access events on the current DAMON results snapshot
> > -and converts it to memory bandwidth consumption estimation in bytes per second.
> > -The resulting metric is exposed to user via this read-only parameter. Because
> > -DAMON uses sampling, this is only an estimation of the access intensity rather
> > -than accurate memory bandwidth.
> > +and converts them to memory bandwidth consumption estimation in bytes per
> > +second. The resulting metric is exposed to user via this read-only parameter.
> > +Because DAMON uses sampling, this is only an estimation of the access intensity
> > +rather than accurate memory bandwidth.
> >
> > memory_idle_ms_percentiles
> > --------------------------
>
>
> Thanks,
> Reviewed-by: Manuel Ebner <manuelebnerli@xxxxxxxxxxx>
Thank you for your review.
Thanks,
SJ