RE: [PATCH v24 08/15] mmc: renesas_sdhi: Add TMIO_MMC_INTERNAL_DIVIDER flag
From: Biju Das
Date: Mon Oct 26 2026 - 10:47:28 EST
Hi Wolfram,
Thanks for the feedback.
> -----Original Message-----
> From: wsa+renesas <wsa+renesas@xxxxxxxxxxxxxxxxxxxx>
> Sent: 23 October 2026 17:10
> Subject: Re: [PATCH v24 08/15] mmc: renesas_sdhi: Add TMIO_MMC_INTERNAL_DIVIDER flag
>
>
> > See patch[1] has relevant changes.
>
> OK, fair enough, but I don't understand the HS400 details yet. Let's postpone further potential
> refactoring to the time when we talk about
> HS400 support. For the time being, can we change this:
>
> > + if (host->pdata->flags & TMIO_MMC_INTERNAL_DIVIDER)
> > + clkh_shift = 1;
>
> to
>
> + /* internal /2 divider is always active here */
> + if (host->pdata->flags & TMIO_MMC_INTERNAL_DIVIDER)
> + clkh_shift--;
>
> so I will hopefully remember these details then?
OK.
>
> With that, I think we have all items discussed for this series, so you should have everything you need
> for a v25 then?
Yes. I agree. I will post v25 after testing.
Cheers,
Biju