Re: [PATCH v4] scsi: ufs: Change the error check sequence for auto hibern8

[Bart Van Assche]

On 10/26/26 7:42 AM, Stanley Jhu wrote:
> On Mon, Oct 26, 2026 at 02:26:32PM +0900, HOYOUNG SEO wrote:
> > v2: https://lore.kernel.org/linux-scsi/20261022074249.3098100-1- 
> > hy50.seo@xxxxxxxxxxx/
>
> > Signed-off-by: HOYOUNG SEO <hy50.seo@xxxxxxxxxxx>
> > ---
>
> Please move it above "---".
>
> > +    if (ufshcd_is_auto_hibern8_error(hba, intr_status)) {
> > +        hba->errors |= (UFSHCD_UIC_HIBERN8_MASK & intr_status);
> > +
> >       cmd = hba->active_uic_cmd;
>
> This brace is never closed, so ufshcd.c does not build.

Hi Hoyoung,

Stanley's comments need to be addressed: please compile-test v5 and move
the Signed-off-by above "---". Additionally, please consider using a
local bool for the ufshcd_is_auto_hibern8_error() result instead of
testing hba->errors, describe the actual changes in the changelog, link
to all previous versions and Cc stable. With these addressed the
approach looks good to me.

Thanks,

Bart.