Re: [PATCH] media: dm1105: fix rc_dev leak on probe error paths

[Markus Elfring]

> dm1105_ir_init() registers an rc_dev that must be cleaned up by
> dm1105_ir_exit().  However, in dm1105_probe() the return value of
> dm1105_ir_init() is ignored, and neither the workqueue nor the
…

I propose to refine the change description another bit.

Wording suggestion:
The return value of a dm1105_ir_init() call was ignored within dm1105_probe().
The error detection and exception handling was incomplete.
Thus add a needed condition check.
Adjust a subsequent jump target for the completion of the desired error handling.


…
> ---
>  drivers/media/pci/dm1105/dm1105.c | 8 ++++++--
…

Some contributors would appreciate patch version descriptions.
https://lore.kernel.org/all/?q=%22This+looks+like+a+new+version+of+a+previously+submitted+patch%22
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v7.3#n310

Regards,
Markus