[PATCH 14/15] thermal/drivers/samsung: acpm-tmu: Clean up probe error logging

From: Tudor Ambarus

Date: Mon Oct 26 2026 - 12:10:28 EST


platform_get_irq(), devm_thermal_add_hwmon_sysfs(), and
devm_request_threaded_irq() already log an error or warning message
internally on failure, so drop the duplicate call-site messages in
acpm_tmu_probe(). Also update the copy-pasted "Unable to map syscon
registers" message on devm_regmap_field_bulk_alloc() failure to "Failed
to allocate regmap fields".

Signed-off-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxx>
---
drivers/thermal/samsung/acpm-tmu.c | 10 +++-------
1 file changed, 3 insertions(+), 7 deletions(-)

diff --git a/drivers/thermal/samsung/acpm-tmu.c b/drivers/thermal/samsung/acpm-tmu.c
index fd491b4f305d..bce4674be58e 100644
--- a/drivers/thermal/samsung/acpm-tmu.c
+++ b/drivers/thermal/samsung/acpm-tmu.c
@@ -444,7 +444,7 @@ static int acpm_tmu_probe(struct platform_device *pdev)
data->reg_fields, REG_INTPEND_COUNT);
if (ret)
return dev_err_probe(dev, ret,
- "Unable to map syscon registers\n");
+ "Failed to allocate regmap fields\n");

priv->clk = devm_clk_get(dev, NULL);
if (IS_ERR(priv->clk))
@@ -453,7 +453,7 @@ static int acpm_tmu_probe(struct platform_device *pdev)

priv->irq = platform_get_irq(pdev, 0);
if (priv->irq < 0)
- return dev_err_probe(dev, priv->irq, "Failed to get irq\n");
+ return priv->irq;

pm_runtime_set_autosuspend_delay(dev, 100);
pm_runtime_use_autosuspend(dev);
@@ -494,16 +494,12 @@ static int acpm_tmu_probe(struct platform_device *pdev)
}
sensor->tzd = tzd;

- ret = devm_thermal_add_hwmon_sysfs(dev, sensor->tzd);
- if (ret)
- dev_warn(dev, "Failed to add hwmon sysfs!\n");
+ devm_thermal_add_hwmon_sysfs(dev, sensor->tzd);
}

ret = devm_request_threaded_irq(dev, priv->irq, NULL,
acpm_tmu_thread_fn, IRQF_ONESHOT,
dev_name(dev), priv);
- if (ret)
- ret = dev_err_probe(dev, ret, "Failed to request irq\n");

out_pm_put:
pm_runtime_put_autosuspend(dev);

--
2.56.0.257.gf7497c7d27-goog