Re: [PATCH] drivers/staging/media/atomisp: Initialize curr_rules in atomisp_freq_scaling
From: Greg KH
Date: Mon Oct 26 2026 - 12:38:22 EST
On Mon, Oct 26, 2026 at 04:10:58PM +0000, Abdullah Mohammd Sifat wrote:
> The local structure 'curr_rules' is declared on the stack but is
> not initialized. Initialize it to zero using empty brackets '{}'
> to prevent potential information leakage of stack garbage values.
>
> Signed-off-by: Abdullah Mohammd Sifat <sifat.yt.2.0c@xxxxxxxxx>
> ---
> drivers/staging/media/atomisp/pci/atomisp_cmd.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/media/atomisp/pci/atomisp_cmd.c b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> index e66a7d1c7a0e..d4de2bd9a0a5 100644
> --- a/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> +++ b/drivers/staging/media/atomisp/pci/atomisp_cmd.c
> @@ -170,7 +170,6 @@ static int write_target_freq_to_hw(struct atomisp_device *isp,
> dev_err(isp->dev, "DFS target freq is rejected by HW.\n");
> return -EINVAL;
> }
> -
> return 0;
> }
>
That's not what this change does here :(