Re: [PATCH v3 0/3] pinctrl: sunxi: number the IRQ banks from the first one that has IRQs

[Andre Przywara]

Hi Pablo,

just some heads up about process:
- Please do not repost that quickly! The kernel doc says to wait at 
least a day, but that's only the lower limit, in case the series is 
almost ready and there were only minor comments from real(!) reviewers.
I would wait for a couple of days, after you got some proper reviews.
The reason is that reviews (by humans) take time, and it's not like 
people are bored waiting for some patches to look at. So they might be 
interrupted by something or need to do some checks and research. It's 
pretty bad if their effort is ambushed by a new revision, which now 
means they need to start over.
- Please do not repost just because Sashiko said something. Wait for a 
proper review. It's probably a good idea to acknowledge the comment, but 
don't just re-post then.
- Try to avoid posting inside the merge window. Depending on the 
subsystem and maintainer, your posts might just be ignored, because they 
might be busy fixing up conflicts. But more importantly: you are missing 
the correct base: you should always base your patches on an -rc1, unless 
being told otherwise explicitly. And since -rc1 won't be out till 
Sunday, this is not a good timing.

I will comment on the patch set separately.

Cheers,
Andre


On 10/25/26 15:24, Pablo Mazzini wrote:
> The DT pinctrl helper numbers the IRQ banks from PA, even when PA has
> none. The A523 got a DT interrupt for its unimplemented PA bank to work
> around that, the A733 would need the same, and on both PK is written
> past the end of irq_array.
>
> Number the IRQ banks like the static drivers do, with irq_bank_map for
> the A523 and A733, and drop the PA interrupt from the binding and the
> A523 DT. The B288 (IRQ banks on PB, PD, PF and PG) then needs no
> made-up interrupt.
>
> v3:
> - apply irq_bank_map to the A733 register layout too (Sashiko)
>
> v2:
> - give the A523 and A733 an irq_bank_map, and drop the PA interrupt
>    from the binding and the A523 DT
>
> Pablo Mazzini (3):
>    pinctrl: sunxi: dt: number the IRQ banks from the first one that has
>      IRQs
>    dt-bindings: pinctrl: sun55i-a523: one interrupt per implemented bank
>    arm64: dts: allwinner: a523: drop the PA GPIO interrupt
>
>   .../bindings/pinctrl/allwinner,sun55i-a523-pinctrl.yaml   | 8 ++++----
>   arch/arm64/boot/dts/allwinner/sun55i-a523.dtsi            | 3 +--
>   drivers/pinctrl/sunxi/pinctrl-sun55i-a523.c               | 2 +-
>   drivers/pinctrl/sunxi/pinctrl-sun60i-a733.c               | 5 ++++-
>   drivers/pinctrl/sunxi/pinctrl-sunxi-dt.c                  | 8 +++-----
>   drivers/pinctrl/sunxi/pinctrl-sunxi.h                     | 7 ++++---
>   6 files changed, 17 insertions(+), 16 deletions(-)
>
>
> base-commit: 4f0dbdbdb3ad122e8bbfb1d722fd584bac7124db