Re: ALSA: hda/cs35l56: same calibration condition logged at dev_info() and dev_err()

[Richard Fitzgerald]

On 14/09/2026 1:03 am, Navon John Lukose wrote:
> Documentation/sound/codecs/cs35l56.rst says "Failed to write calibration"
> has the "same meaning and cause as 'Calibration disabled due to missing
> firmware controls'". The latter is a dev_info(). The former is a dev_warn()
> with a dev_err() from cs_amp_write_cal_coeff() ahead of it.
>
> Rebinding the HDA components without re-probing the i2c driver takes the
> loud path, 4 of 4 attempts here:
>
>      cs35l56-hda i2c-CSC3556:00-cs35l56-hda.0: Failed to write to 'CAL_R': -1
>      cs35l56-hda i2c-CSC3556:00-cs35l56-hda.0: Failed to write calibration: -1
>
> list_empty() is false because the controls cs_dsp_power_down() disabled at
> unbind are still on ctl_list, so the dev_info() branch is skipped.

I've been looking at what code changes would be needed to fix this.
I'm not convinced that there is enough reason to fix this unbind-rebind
problem. There are risks in trying to fix it.

I don't know of a reason why the driver needs to be unbound and rebound
in normal operation. For debugging, the driver can be unloaded and
reloaded to force a probe.

I'd prefer only a documentation update to note that this error could
be caused by unbinding and rebinding the driver without reprobing.