Re: [PATCH v2 3/6] ata: ahci_brcm: Initialize the NSP interface clock and reset
From: Florian Fainelli
Date: Mon Oct 26 2026 - 15:18:18 EST
On 10/26/26 11:28, Florian Fainelli wrote:
The NSP probe path assumes firmware has enabled the SATA IDM interface
clock and released the core reset. The downstream iProc config_AHCI()
sequence explicitly performs both operations before accessing AHCI.
Without that setup, a cold boot can access an inactive controller.
Map the optional NSP IDM register region and enable the interface clock
before releasing reset, retaining the downstream settling intervals.
Perform the sequence at probe and resume before reconfiguring SATA.
Keep the resource optional so older device trees continue to rely on
firmware initialization.
Fixes: 3ee2e6dcaa35 ("ata: ahci_brcm: Add support for Broadcom NSP SoC")
Signed-off-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>
Apologies, this is the same as v1, I will resubmit in a short while.
--
Florian