Re: [PATCH] can: softing: Fix locking in softing_card_shutdown()

[Marc Kleine-Budde]

Hello Bart,

thanks for you contribution.

On 26.10.2026 12:47:07, Bart Van Assche wrote:
> If mutex_lock_interruptible() fails, softing_card_shutdown() goes on
> without holding card->fw.lock and later unlocks that mutex anyway.
> Shutting down cannot fail, so use mutex_lock() instead. This makes
> sure the firmware state is always changed with fw.lock held and that
> only a held mutex is unlocked.
>
> Fixes: 03fd3cf5a179 ("can: add driver for Softing card")
> Signed-off-by: Bart Van Assche <bvanassche@xxxxxxx>

Are you actively using this driver? It's scheduled for removal in the
v7.15.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Attachment: signature.asc
Description: PGP signature