Re: [PATCH v1 2/2] mm: multi-gen LRU: remove get_lruvec()

[Siddharth Chintamaneni]

On Mon, 26 Oct 2026 at 03:00, Barry Song <baohua@xxxxxxxxxx> wrote:
>
> On Thu, Oct 22, 2026 at 7:56 AM Siddharth Chintamaneni
> <sidchintamaneni@xxxxxxxxx> wrote:
> >
> > get_lruvec() was originally introduced in commit ec1c86b25f4b ("mm:
> > multi-gen LRU: groundwork") to guard against NULL NODE_DATA(nid) on
> > uninitialized NUMA nodes (`return pgdat ? &pgdat->__lruvec : NULL;`).
> > After commit 09f49dca570a ("mm: handle uninitialized numa nodes
> > gracefully") and commit 931b6a8b36a2 ("mm: multi-gen LRU: remove NULL
> > checks on NODE_DATA()"), that NULL check was removed, leaving
> > get_lruvec() as a thin wrapper around mem_cgroup_lruvec().
> >
> > Remove get_lruvec() and call mem_cgroup_lruvec() directly at all call
> > sites.
> >
> > Cc: Barry Song <baohua@xxxxxxxxxx>
>
> I guess the correct tag should be "Suggested-by" here?
>
> > Signed-off-by: Siddharth Chintamaneni <sidchintamaneni@xxxxxxxxx>
> > Signed-off-by: Hardik Garg <hargar@xxxxxxxxxxxxxxxxxxx>
> > ---
>
> Your patchset organization is a bit unusual. Patch 2/2 is
> sent as a reply to patch 1/2. I think adding a cover letter
> would help you organize the series properly?
>

re-sent it with your suggestions, Thanks!

> Thanks
> Barry